aboutsummaryrefslogtreecommitdiffstats
path: root/openspec/changes/fix-deprecation-warnings
diff options
context:
space:
mode:
authorGravatar Tom van der Lee <tom@vanderlee.io>2026-09-21 12:27:01 +0200
committerGravatar Tom van der Lee <tom@vanderlee.io>2026-09-21 12:27:01 +0200
commitdb86c80a9931074c574c88a0a7ea5339c06b34f5 (patch)
treebcc1496ca6b41b08f395df248230276e50dfb37b /openspec/changes/fix-deprecation-warnings
parentf8e84b1e18d39632ead22b7c45fe4e97691bed29 (diff)
downloaddesktop-flake-db86c80a9931074c574c88a0a7ea5339c06b34f5.tar.gz
desktop-flake-db86c80a9931074c574c88a0a7ea5339c06b34f5.tar.bz2
desktop-flake-db86c80a9931074c574c88a0a7ea5339c06b34f5.zip
Fix Nix evaluation deprecation warnings
Replace deprecated pkgs.stdenv.isDarwin/isLinux with pkgs.stdenv.hostPlatform.isDarwin/.isLinux, and explicitly pin programs.neovim.withRuby/withPython3 = true so the legacy default doesn't silently change if home.stateVersion is ever bumped. Pure deprecation fixes, no behavior change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BBSd4VBfoKHjE1HR3P8kmn
Diffstat (limited to 'openspec/changes/fix-deprecation-warnings')
-rw-r--r--openspec/changes/fix-deprecation-warnings/.openspec.yaml3
-rw-r--r--openspec/changes/fix-deprecation-warnings/proposal.md22
-rw-r--r--openspec/changes/fix-deprecation-warnings/tasks.md13
3 files changed, 38 insertions, 0 deletions
diff --git a/openspec/changes/fix-deprecation-warnings/.openspec.yaml b/openspec/changes/fix-deprecation-warnings/.openspec.yaml
new file mode 100644
index 0000000..54f2ff0
--- /dev/null
+++ b/openspec/changes/fix-deprecation-warnings/.openspec.yaml
@@ -0,0 +1,3 @@
1schema: spec-driven
2created: 2026-09-21
3skip_specs: true
diff --git a/openspec/changes/fix-deprecation-warnings/proposal.md b/openspec/changes/fix-deprecation-warnings/proposal.md
new file mode 100644
index 0000000..0f1edb5
--- /dev/null
+++ b/openspec/changes/fix-deprecation-warnings/proposal.md
@@ -0,0 +1,22 @@
1## Why
2
3`nixos-rebuild`/`home-manager switch` on a real host now emits four evaluation warnings: `stdenv.isDarwin`/`stdenv.isLinux` are deprecated in favor of `stdenv.hostPlatform.isDarwin`/`.isLinux`, and `programs.neovim.withRuby`/`withPython3` warn that their default is changing and asks for an explicit value while `home.stateVersion` stays below "26.05". Left unset, these warnings will keep appearing on every activation, and the neovim providers' actual default would change out from under this flake the moment `stateVersion` is ever bumped, with no record of that being an intentional choice.
4
5## What Changes
6
7- Replace every `pkgs.stdenv.isDarwin`/`pkgs.stdenv.isLinux` usage with `pkgs.stdenv.hostPlatform.isDarwin`/`.isLinux` (`users/tom.nix`, `modules/home/dotfiles.nix`). Pure rename with identical semantics — no behavior change.
8- Explicitly set `programs.neovim.withRuby = true;` and `programs.neovim.withPython3 = true;` in `modules/home/editor.nix`, pinning today's legacy-default behavior on purpose rather than leaving it implicit and version-dependent. No behavior change.
9
10## Capabilities
11
12### New Capabilities
13(none)
14
15### Modified Capabilities
16(none — every change here preserves current externally observable behavior exactly; only the deprecated attribute names and an implicit default become explicit. `.openspec.yaml` sets `skip_specs: true` accordingly.)
17
18## Impact
19
20- Affected code: `users/tom.nix`, `modules/home/dotfiles.nix`, `modules/home/editor.nix`.
21- Affects every `homeConfigurations`/`nixosConfigurations` output built from the shared home profile, on both NixOS and Darwin.
22- Out of scope: the "Git tree is dirty" notice in the pasted warnings is expected uncommitted-changes noise from evaluating a local checkout, not a deprecation — not addressed here. Also out of scope: bumping `home.stateVersion` itself, which would pull in a much broader set of home-manager default changes beyond these two neovim options.
diff --git a/openspec/changes/fix-deprecation-warnings/tasks.md b/openspec/changes/fix-deprecation-warnings/tasks.md
new file mode 100644
index 0000000..0ffedfb
--- /dev/null
+++ b/openspec/changes/fix-deprecation-warnings/tasks.md
@@ -0,0 +1,13 @@
1## 1. Replace deprecated `stdenv.isDarwin`/`isLinux`
2
3- [x] 1.1 In `users/tom.nix`, replace `pkgs.stdenv.isDarwin` with `pkgs.stdenv.hostPlatform.isDarwin` in the `home.homeDirectory` conditional — verify by reading the file back and confirming the Darwin/Linux home path logic is otherwise unchanged
4- [x] 1.2 In `modules/home/dotfiles.nix`, replace `pkgs.stdenv.isDarwin`/`pkgs.stdenv.isLinux` with `pkgs.stdenv.hostPlatform.isDarwin`/`.isLinux` in `platformDefaultExcludes` — verify by reading the file back and confirming the excluded-package lists (`iterm2` on non-Darwin; `herbstluftwm`/`xorg` on non-Linux) are unchanged
5- [x] 1.3 Verify via `grep -rn "stdenv.isDarwin\|stdenv.isLinux" --include="*.nix" .` that no remaining usage exists outside `hosts/template/` (if any) (verified: zero matches anywhere in the repo, including `hosts/template/`)
6
7## 2. Pin Neovim provider defaults explicitly
8
9- [x] 2.1 In `modules/home/editor.nix`, add `withRuby = true;` and `withPython3 = true;` to the `programs.neovim` block — verify by reading the file back
10
11## 3. Validate
12
13- [x] 3.1 Run `nix flake check` (or `nixos-rebuild build`/`home-manager build`, wherever Nix is available) and confirm the four deprecation warnings no longer appear and all outputs still evaluate cleanly (blocked — Nix is not installed on this machine; run this once Nix is available, e.g. on the real host where the original warnings were observed — this is the real acceptance gate, not the individual checkboxes above). Reviewed manually instead: all three edited files were read back and are syntactically well-formed; `pkgs.stdenv.hostPlatform.isDarwin`/`.isLinux` is a straight rename of the same attribute path nixpkgs' `stdenv` exposes, and `withRuby`/`withPython3 = true;` matches the exact value the warning said was already in effect, so no other behavior should change