diff options
| author | 2026-09-21 12:27:01 +0200 | |
|---|---|---|
| committer | 2026-09-21 12:27:01 +0200 | |
| commit | db86c80a9931074c574c88a0a7ea5339c06b34f5 (patch) | |
| tree | bcc1496ca6b41b08f395df248230276e50dfb37b /openspec/changes/fix-deprecation-warnings/tasks.md | |
| parent | f8e84b1e18d39632ead22b7c45fe4e97691bed29 (diff) | |
| download | desktop-flake-db86c80a9931074c574c88a0a7ea5339c06b34f5.tar.gz desktop-flake-db86c80a9931074c574c88a0a7ea5339c06b34f5.tar.bz2 desktop-flake-db86c80a9931074c574c88a0a7ea5339c06b34f5.zip | |
Fix Nix evaluation deprecation warnings
Replace deprecated pkgs.stdenv.isDarwin/isLinux with
pkgs.stdenv.hostPlatform.isDarwin/.isLinux, and explicitly pin
programs.neovim.withRuby/withPython3 = true so the legacy default
doesn't silently change if home.stateVersion is ever bumped. Pure
deprecation fixes, no behavior change.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BBSd4VBfoKHjE1HR3P8kmn
Diffstat (limited to 'openspec/changes/fix-deprecation-warnings/tasks.md')
| -rw-r--r-- | openspec/changes/fix-deprecation-warnings/tasks.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/openspec/changes/fix-deprecation-warnings/tasks.md b/openspec/changes/fix-deprecation-warnings/tasks.md new file mode 100644 index 0000000..0ffedfb --- /dev/null +++ b/openspec/changes/fix-deprecation-warnings/tasks.md | |||
| @@ -0,0 +1,13 @@ | |||
| 1 | ## 1. Replace deprecated `stdenv.isDarwin`/`isLinux` | ||
| 2 | |||
| 3 | - [x] 1.1 In `users/tom.nix`, replace `pkgs.stdenv.isDarwin` with `pkgs.stdenv.hostPlatform.isDarwin` in the `home.homeDirectory` conditional — verify by reading the file back and confirming the Darwin/Linux home path logic is otherwise unchanged | ||
| 4 | - [x] 1.2 In `modules/home/dotfiles.nix`, replace `pkgs.stdenv.isDarwin`/`pkgs.stdenv.isLinux` with `pkgs.stdenv.hostPlatform.isDarwin`/`.isLinux` in `platformDefaultExcludes` — verify by reading the file back and confirming the excluded-package lists (`iterm2` on non-Darwin; `herbstluftwm`/`xorg` on non-Linux) are unchanged | ||
| 5 | - [x] 1.3 Verify via `grep -rn "stdenv.isDarwin\|stdenv.isLinux" --include="*.nix" .` that no remaining usage exists outside `hosts/template/` (if any) (verified: zero matches anywhere in the repo, including `hosts/template/`) | ||
| 6 | |||
| 7 | ## 2. Pin Neovim provider defaults explicitly | ||
| 8 | |||
| 9 | - [x] 2.1 In `modules/home/editor.nix`, add `withRuby = true;` and `withPython3 = true;` to the `programs.neovim` block — verify by reading the file back | ||
| 10 | |||
| 11 | ## 3. Validate | ||
| 12 | |||
| 13 | - [x] 3.1 Run `nix flake check` (or `nixos-rebuild build`/`home-manager build`, wherever Nix is available) and confirm the four deprecation warnings no longer appear and all outputs still evaluate cleanly (blocked — Nix is not installed on this machine; run this once Nix is available, e.g. on the real host where the original warnings were observed — this is the real acceptance gate, not the individual checkboxes above). Reviewed manually instead: all three edited files were read back and are syntactically well-formed; `pkgs.stdenv.hostPlatform.isDarwin`/`.isLinux` is a straight rename of the same attribute path nixpkgs' `stdenv` exposes, and `withRuby`/`withPython3 = true;` matches the exact value the warning said was already in effect, so no other behavior should change | ||
